|
Size: 1184
Comment:
|
Size: 1186
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 3: | Line 3: |
| * People: Marco Streng, Mak Trifkovic, Peter Bruin, John Cremona | * People: Marco Streng, Mak Trifkovic, Peter Bruin, John Cremona |
| Line 5: | Line 5: |
| * This is Trac ticket 727: http://trac.sagemath.org/sage_trac/ticket/727 | * This is Trac ticket 727: http://trac.sagemath.org/sage_trac/ticket/727 |
| Line 9: | Line 9: |
| * Uses Denis Simon's pari code for solving and parametrizing conics over QQ | * Uses Denis Simon's pari code for solving and parametrizing conics over QQ |
| Line 11: | Line 11: |
| * Uses pari's rnfisnorm for finding points on conics over number fields | * Uses pari's rnfisnorm for finding points on conics over number fields |
| Line 13: | Line 13: |
| * Solves conics over finite fields and RR and CC. | * Solves conics over finite fields and RR and CC. |
| Line 17: | Line 17: |
| * I forgot to include "sage/schemes/plane_conics/__init__.py" (which is empty), so the patch actually doesn't work | * I forgot to include "sage/schemes/plane_conics/__init__.py" (which is empty), so the patch actually doesn't work |
| Line 19: | Line 19: |
| * Use a good Hilbert symbol, such as the one of Trac ticket 9334 or the one of Pari. http://trac.sagemath.org/sage_trac/ticket/9334 | * Use a good Hilbert symbol, such as the one of Trac ticket 9334 or the one of Pari. http://trac.sagemath.org/sage_trac/ticket/9334 |
| Line 21: | Line 21: |
| * Make a hierarchy of Conic classes (modelled after the hierarchy of Elliptic curve classes?), each with special functionality | * Make a hierarchy of Conic classes (modelled after the hierarchy of Elliptic curve classes?), each with special functionality |
| Line 23: | Line 23: |
| * Fix broken doctests: | * Fix broken doctests: |
| Line 25: | Line 25: |
| sage -t "sage/schemes/plane_conics/conic_solve.py" | * sage -t "sage/schemes/plane_conics/conic_solve.py" |
| Line 27: | Line 27: |
| sage -t "sage/schemes/plane_conics/hilbert.py" | * sage -t "sage/schemes/plane_conics/hilbert.py" |
| Line 29: | Line 29: |
| sage -t "sage/schemes/plane_conics/projective_conic.py | * sage -t "sage/schemes/plane_conics/projective_conic.py |
| Line 31: | Line 31: |
| * Add missing doctests (e.g. pickling) | * Add missing doctests (e.g. pickling) |
| Line 33: | Line 33: |
| * Change the constructor of Curve to return a Conic if the curve is a Conic | * Change the constructor of Curve to return a Conic if the curve is a Conic |
Coding Sprint Project: Solving Conics
- People: Marco Streng, Mak Trifkovic, Peter Bruin, John Cremona
This is Trac ticket 727: http://trac.sagemath.org/sage_trac/ticket/727
Conic class currently available at the ticket
- Uses Denis Simon's pari code for solving and parametrizing conics over QQ
- Uses pari's rnfisnorm for finding points on conics over number fields
- Solves conics over finite fields and RR and CC.
To do
I forgot to include "sage/schemes/plane_conics/init.py" (which is empty), so the patch actually doesn't work
Use a good Hilbert symbol, such as the one of Trac ticket 9334 or the one of Pari. http://trac.sagemath.org/sage_trac/ticket/9334
- Make a hierarchy of Conic classes (modelled after the hierarchy of Elliptic curve classes?), each with special functionality
- Fix broken doctests:
- sage -t "sage/schemes/plane_conics/conic_solve.py"
- sage -t "sage/schemes/plane_conics/hilbert.py"
- sage -t "sage/schemes/plane_conics/projective_conic.py
- Add missing doctests (e.g. pickling)
- Change the constructor of Curve to return a Conic if the curve is a Conic