Differences between revisions 13 and 14
Revision 13 as of 2008-05-20 01:31:20
Size: 1828
Editor: JasonBandlow
Comment:
Revision 14 as of 2008-05-20 01:59:05
Size: 2198
Editor: JasonBandlow
Comment:
Deletions are marked like this. Additions are marked like this.
Line 28: Line 28:
 * Necklaces are not defined in the docstring
 * PartitionsGreatestEQ, PartitionsGreatestLE, PartitionsInBox are redundant with Partitions
 * For the following comments, let p be a partition:
 * p.arm_lengths() should be called.p_arm_length_tableau()
 * p.arm_legs_coeff() is not explained
 * p.associated is an alias for p.conjugate. Is it necessary to have?
 *

Weirdness

  • sage.combinat.word is not imported by default
  • word.symmetric_group_action_on_values does not naturally belong in word
  • word.standard should be called word.standardization
  • word.charge returns the cocharge
  • CombinatorialAlgebra has no useful documentation

  • CombinatorialClass has no documentation

  • It would be nice for CombinatorialObject to have a method 'indices' which returns a list of the index of *every* occurrence of x

  • Compositions has no option for allowing '0' parts (which are often useful) (IntegerVectors does this. There should be a pointer.)

  • Composition.conjugate() is not explained
  • Composition.descents() is not explained
  • Composition.major_index() doc-string says it is the sum of the descents. This is not true for the given example.
  • Composition.refinement() is not explained
  • SignedCompositions has no corresponding class SignedComposition

  • DyckWords? does not define Dyck words

  • DyckWord.b_statistic() is not explained

  • DyckWord.height() is not explained

  • DyckWord.peaks() is not explained

  • DyckWord.to_noncrossing_partition() could use a better reference

  • DyckWord.to_tableau is not explained

  • DyckWord.to_* for * in {ordered_tree, triangulation} is not implemented. Warning: Implementing bijections between Catalan objects can be a never-ending task.

  • IntegerVectors has no corresponding class IntegerVector (or Word, etc.)

  • WeightedIntegerVectors has no corresponding class WeightedIntegerVector (or IntegerVector, or Word, etc.)

  • LyndonWords has no corresponding class LyndonWord (or Word, etc.)

  • LyndonWords are not defined in the docstring

  • MultichooseNK has no useful documentation
  • The name MultichooseNK does not compare well with Combinations, though they do very similar things
  • Necklaces are not defined in the docstring
  • PartitionsGreatestEQ, PartitionsGreatestLE, PartitionsInBox are redundant with Partitions

  • For the following comments, let p be a partition:
  • p.arm_lengths() should be called.p_arm_length_tableau()
  • p.arm_legs_coeff() is not explained
  • p.associated is an alias for p.conjugate. Is it necessary to have?

combinat/Weirdness (last edited 2018-11-06 19:45:34 by chapoton)